[PATCH] D144081: InstCombine: Fold and/or of fcmp into class

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 08:47:27 PST 2023


foad added subscribers: nikic, craig.topper.
foad added a comment.

> I swear I posted this before but can't seem to find it

It was in the origincal incarnation of https://reviews.llvm.org/D139130?vs=on&id=479367



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1503
+  // single fcmp with fneg and fabs, that's likely a better canonical form.
+  if (LHS->hasOneUse() && RHS->hasOneUse()) {
+    auto [ClassValRHS, ClassMaskRHS] = fcmpToClassTest(PredR, RHS0, RHS1);
----------------
Do you need to worry about `IsLogicalSelect` here? (@nikic, @craig.topper?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144081/new/

https://reviews.llvm.org/D144081



More information about the llvm-commits mailing list