[PATCH] D143713: [ARM] Fix Chain/Glue Bug in PerformVMOVhrCombine

Mon Feb 20 08:21:51 PST 2023

lenary added a comment.

In D143713#4122025 <https://reviews.llvm.org/D143713#4122025>, @dmgreen wrote:

> Sounds OK if you can clear up the tests. It might be worth making sure there is a test with multiple uses too.

Do you mean the AES pass tests? Do you think that should happen before we land this, they've been an issue for a little while.

================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:15006
+  //     t2: f32,ch1,gl1? = CopyFromReg ch, Register:f32 %0, gl?
+  //   t5: i32 = bitcast t2 t18: f16 = ARMISD::VMOVhr t5
   // t18: f16 = ARMISD::VMOVhr t5
----------------
dmgreen wrote:
> Can remove the extra `t18: f16 = ARMISD::VMOVhr t5`?
Ack

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143713/new/

https://reviews.llvm.org/D143713