[PATCH] D142545: [ConstraintElimination] Add tests to check for `or` instruction decomposition if a constant operand is < 2^known_zero_bits of the first operand.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 20 05:32:38 PST 2023
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, with the suggested additional cleanup
================
Comment at: llvm/test/Transforms/ConstraintElimination/or.ll:471
+ %start = shl nuw nsw i8 %init_val, 2
+ %add.ptr.i = add nuw i8 %start, 3
+ %c.1 = icmp uge i8 %add.ptr.i, %high
----------------
Could you rename this variable? maybe `%start.plus.3`?
also, remove the dead `%low` argument.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142545/new/
https://reviews.llvm.org/D142545
More information about the llvm-commits
mailing list