[PATCH] D144368: Use transfer by reference instead of value to make some space more efficient

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 02:30:27 PST 2023


skan requested changes to this revision.
skan added a comment.
This revision now requires changes to proceed.

Do not use simple "I think these members are big enough" here. "auto" is used for type here and the concrete type is not explicit for the reviewers.  Please provide more justification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144368/new/

https://reviews.llvm.org/D144368



More information about the llvm-commits mailing list