[PATCH] D139455: AMDGPU: Document denormal behavior

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 01:20:38 PST 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

Seems like an obvious incremental improvement to mention this, irrespective of any nits in the wording.



================
Comment at: llvm/docs/AMDGPUUsage.rst:4596
+     by ``"denormal-fp-math"="preserve-sign"``. The behavior is
+     undefined with ``"denormal-fp-math"="positive-zero"``
+
----------------
If we can't implement flushing-to-positive-zero then surely we should treat "denormal-fp-math"="positive-zero" the same as "denormal-fp-math"="ieee", since according to LangRef "it is not mandated that flushing to zero occurs" at all. So I don't see where undefined behaviour comes into it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139455/new/

https://reviews.llvm.org/D139455



More information about the llvm-commits mailing list