[PATCH] D144301: [dwarfdump][AMDGPU] Support EF_AMDGPU_MACH_NONE

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The patch title and code are to do with llvm-dwarfdump, but the commit message refers to llvm-objdump. Is this just a mistake?



================
Comment at: llvm/lib/Object/RelocationResolver.cpp:260
+/// identify their arch as either r600 or amdgcn, but we can still handle
+/// their relocations. When we identify a ELF object with an UnknownArch,
+/// we use isUnknownAMDGPU to check for this case.
----------------
Nit


================
Comment at: llvm/lib/Object/RelocationResolver.cpp:849-850
+        return {supportsAmdgpu, resolveAmdgpu};
+      else
+        return {nullptr, nullptr};
     }
----------------
No need for `else` after `return`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144301/new/

https://reviews.llvm.org/D144301