[PATCH] D143837: [llvm] Deprecate llvm::count{Leading,Trailing}{Zeros,Ones} and llvm::countPopulation
Kazu Hirata via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 12 13:42:40 PST 2023
kazu added inline comments.
================
Comment at: llvm/unittests/Support/MathExtrasTest.cpp:66
- }
-}
-
----------------
RKSimon wrote:
> I'm not sure what our policy is regarding test coverage - but I'd expect these to stay until we actually remove the functions being tests?
I think I have to remove these tests. Leaving them would cause warnings, so that would in turn block `-Werror` builds. In any event, I think the risk is pretty low; I deprecate functions after migrate their uses first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143837/new/
https://reviews.llvm.org/D143837
More information about the llvm-commits
mailing list