[PATCH] D143796: [SelectionDAG] Negate constant offset before morphing load/store node with pre-dec/post-dec addressing mode.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 12 12:15:41 PST 2023
efriedma added a comment.
The way this fix is implemented seems suspicious. As far as I can tell, this would basically imply that PRE_DEC never worked on any target. A quick grep shows three targets using it. If the other targets are working, we should probably be fixing this in AArch64-specific code.
Apparently, the AArch64 backend can also generate PRE_INC operations with a negative offset, which might explain why nobody noticed this issue before on AArch64.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143796/new/
https://reviews.llvm.org/D143796
More information about the llvm-commits
mailing list