[PATCH] D143804: [bazel] create a clang-tidy binary target
Aaron Siddhartha Mondal via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 12 11:51:26 PST 2023
aaronmondal added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/clang-tools-extra/clang-tidy/BUILD.bazel:5-8
+load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
+load("defs.bzl", "clang_tidy_library")
+load("@bazel_skylib//rules:native_binary.bzl", "native_binary")
+load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
----------------
These includes look out of order.
Ah I remember having issues like this as well where buildifier wouldn't apply some warnings/fixes like sorting.
It's probably because some warnings/fixes are only raises/applied if `-lint` is set to `warn`/`fix`. Confusingly, the default for that flag is `off`. Maybe `-warnings=all` needs to be set as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143804/new/
https://reviews.llvm.org/D143804
More information about the llvm-commits
mailing list