[PATCH] D139092: [RFC][LLD][ELF] Cortex-M Security Extensions (CMSE) Support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.h:1243
+// The symbol from the import library should have a specified size.
+class ArmCmseFixedAddressSGVeneer final : public ArmCmseSGVeneer {
+public:
----------------
I don't think deriving from `ArmCmseSGVeneer` is useful. We just need `std::optional<uint64_t> entAddr;` to differentiate the two subclasses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092