[PATCH] D140460: [RISCV][MC] Add FLI instruction support for the experimental zfa extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:302
+    unsigned Val;
+    bool IsRV64;
+  };
----------------
Is this IsRV64 field used ever?


================
Comment at: llvm/test/MC/RISCV/zfa-valid.s:197
+# CHECK-NO-EXT: error: instruction requires the following: 'Zfa' (Additional Floating-Point){{$}}
+fli.d ft1, 1.1754943508222875079687365372222456778186655567720875215087517062784172594547271728515625e-38
+
----------------
This isn't the correct min value for double precision


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460