[PATCH] D143802: [XRay] Make patchable-function-entry NOP sled implementation target-independent

Fri Feb 10 19:43:40 PST 2023

duck-37 added a comment.

In D143802#4119979 <https://reviews.llvm.org/D143802#4119979>, @MaskRay wrote:

>> Fixes https://github.com/llvm/llvm-project/issues/60672
>
> It's not a bug so I'd use `Close`. Note: without runtime support, the compiler codegen change isn't really useful

Sure, I'll adjust that for the next revision. The main idea here was consistency across architectures; I came across this while moving a test-case over to ARM32 and noticing a difference in the behavior.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143802/new/

https://reviews.llvm.org/D143802