[PATCH] D143526: [GlobalISel] Handle ptr size != index size in IRTranslator

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 16:32:28 PST 2023


arsenm accepted this revision.
arsenm added a comment.

GlobalISel part lgtm but the cgp part should be split out



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6047
       LLVMContext &Ctx = GEP->getContext();
-      Type *IntPtrTy = DL->getIntPtrType(GEP->getType());
+      Type *PtrIdxTy = DL->getPtrIndexType(GEP->getType());
       Type *I8PtrTy =
----------------
arsenm wrote:
> Some addressing mode thing, probably would be best to hack up a test that hits an unreachable here
CGP part is still separate and separately testable 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143526/new/

https://reviews.llvm.org/D143526



More information about the llvm-commits mailing list