[PATCH] D142556: [DebugInfo] Merge partially matching chains of inlined locations

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D142556#4110809 <https://reviews.llvm.org/D142556#4110809>, @dstenb wrote:

> In D142556#4103178 <https://reviews.llvm.org/D142556#4103178>, @dblaikie wrote:
>
>> Numbers look fairly good - wonder if you could get this run through the LLVM perf tracker to get some more stable/precise numbers?
>
> Just to make sure, is that https://llvm-compile-time-tracker.com/? I can try, otherwise I'll build binaries on a smaller machine that is otherwise unused during the nights, to get rid of most of the noise.

Yeah, that's the one I meant.

>> & any chance you could use something like bloaty ( https://github.com/google/bloaty ) or by hand comparison on a per-section basis on the clang binary? Getting a sense of, specifically, how much bigger this makes .debug_info (but any incidental changes to other sections too) might be helpful
>
> Here are results for the above mentioned RelWithDebInfo opt build:
>
>   $ bloaty normal/build-with/bin/opt -- normal/build-without/bin/opt 
>       FILE SIZE        VM SIZE    
>    --------------  -------------- 
>     +101%  +924Ki  [ = ]       0    .debug_info
>     +100%  +179Ki  [ = ]       0    .debug_str
>     +101%  +146Ki  [ = ]       0    .debug_line
>     +101%  +123Ki  [ = ]       0    .debug_addr
>     +102%  +112Ki  [ = ]       0    .debug_rnglists
>     +101% +31.6Ki  [ = ]       0    .debug_abbrev
>     +100% +16.9Ki  [ = ]       0    .debug_str_offsets
>     +100%    +543  [ = ]       0    .debug_loclists
>     +100%     -18  [ = ]       0    .debug_line_str
>     +100%  +324Mi  +100% +35.6Mi    TOTAL

I'm a bit confused by all these reports - at least with my `bloaty` locally, "+100%" would mean the section doubled in size (100% growth) but it shows "+100%" even for a section that shrunk (.debug_line_str) slightly... Confusing.

but the overall numbers still sound OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142556/new/

https://reviews.llvm.org/D142556