[PATCH] D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms

Fri Feb 10 14:29:55 PST 2023

dblaikie added subscribers: JDevlieghere, aprantl.
dblaikie added a comment.

In D142283#4114093 <https://reviews.llvm.org/D142283#4114093>, @luismarques wrote:

> In D142283#4092092 <https://reviews.llvm.org/D142283#4092092>, @dblaikie wrote:
>
>> Ah, so how does a debugger find debug info without these sort of hints? Could that logic be reused in llvm-symbolizer? (are there other symbolizers (addr2line, etc) that work on MacOS? How do they find the debug info?)
>
> I provided this more expedient patch exactly because I suspected that finding out the answers to those questions and implementing the missing logic was going to be non-trivial. For me, this was initially just a weekend patch to make stack traces work properly on macOS, as contributing to LLVM's Darwin support is a bit outside of my current professional scope. Still, if no one else steps up in the meantime I expect I'll eventually get around to doing that investigation and proper implementation, but it might take a while. I'll reference any follow-up patches or investigation results here.

Fiar enough, for sure. Though in this case we might be able to skip the research and ask the people who work on lldb - @aprantl @JDevlieghere do either of you happen to know how the debugger finds .o or dsyms for debugging? Could that be reasonably implemented in llvm-symbolizer so it just "does the right thing" and finds debug info itself without the need for extra hints? (hmm, I guess then there's another question, whether llvm-symbolizer can read the non-dsym debug info in .o files - that'd be ideal, but maybe that's a bunch more work, I'm not sure)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142283/new/

https://reviews.llvm.org/D142283