[PATCH] D143619: [llvm][codegen] Disallow default Emulated TLS for RISCV

Vitaly Cheptsov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 12:10:08 PST 2023


vit9696 resigned from this revision.
vit9696 added a comment.

> @vit9696 perhaps you could remove the "requires changes to proceed" marker, unless you have specific quality of implementation concerns with this patch? It might be we decide to abandon it in favour of enabling emulated TLS, but even if it's just the case that it takes a little longer to agree on that, this patch is still better than the status quo where it sounds like we're generating incorrect code and might be reasonable stop-gap.

Ok.

To all: please do not rush with this patch, as long as the RISC-V implementation is merged, we will have very few reasons to merge it even after changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143619/new/

https://reviews.llvm.org/D143619



More information about the llvm-commits mailing list