[PATCH] D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:3853
   memcpy(buf + 12, kMemtagAndroidNoteName, sizeof(kMemtagAndroidNoteName));
-  buf += 12 + sizeof(kMemtagAndroidNoteName);
+  buf += 12 + alignTo(sizeof(kMemtagAndroidNoteName), 4);
 
----------------
should we have a static_assert that this is aligned to 4 instead? this seems like a no op


================
Comment at: lld/ELF/SyntheticSections.cpp:3868
   return sizeof(llvm::ELF::Elf64_Nhdr) +
-         /*namesz=*/sizeof(kMemtagAndroidNoteName) +
+         /*namesz=*/alignTo(sizeof(kMemtagAndroidNoteName), 4) +
          /*descsz=*/sizeof(uint32_t);
----------------
as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143769/new/

https://reviews.llvm.org/D143769