[PATCH] D139000: [AMDGPU] Remove function with incompatible features

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash accepted this revision.
Joe_Nash added a comment.

LGTM besides my previously noted typo, but please wait for @arsenm



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:1077
+
+  if (RemoveIncompatibleFunctions)
+    addPass(
----------------
foad wrote:
> Joe_Nash wrote:
> > For the sake of compile time, can we avoid running this pass on O2 and O3? We know dead code elimination will remove the functions anyway.
> We don't know that. DCE will only remove a function if the compiler can easily prove that it is never called.
Ok, you're right. I was thinking of device libs only, but this pass can be used more generally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000