[llvm] 76a1919 - [Attributor][NFC] Avoid unnecessary string operations

Joseph Huber via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 09:56:30 PST 2023


Author: Johannes Doerfert
Date: 2023-02-10T11:56:09-06:00
New Revision: 76a19190269be01e60703f4ece4affdcc87d23ca

URL: https://github.com/llvm/llvm-project/commit/76a19190269be01e60703f4ece4affdcc87d23ca
DIFF: https://github.com/llvm/llvm-project/commit/76a19190269be01e60703f4ece4affdcc87d23ca.diff

LOG: [Attributor][NFC] Avoid unnecessary string operations

This caused multiple string operations which we don't need if we do not
create a profile.

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/Attributor.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp
index b11b881cd757..69cd4e0cea8b 100644
--- a/llvm/lib/Transforms/IPO/Attributor.cpp
+++ b/llvm/lib/Transforms/IPO/Attributor.cpp
@@ -2499,9 +2499,9 @@ ChangeStatus Attributor::run() {
 }
 
 ChangeStatus Attributor::updateAA(AbstractAttribute &AA) {
-  TimeTraceScope TimeScope(
-      AA.getName() + std::to_string(AA.getIRPosition().getPositionKind()) +
-      "::updateAA");
+  TimeTraceScope TimeScope("updateAA", [&]() {
+    return AA.getName() + std::to_string(AA.getIRPosition().getPositionKind());
+  });
   assert(Phase == AttributorPhase::UPDATE &&
          "We can update AA only in the update stage!");
 


        


More information about the llvm-commits mailing list