[PATCH] D143703: [NFC][polly] Convert some python scripts to Python 3 syntax

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 09:51:59 PST 2023


thieta added inline comments.


================
Comment at: polly/utils/argparse.py:106
 try:
-    _basestring = basestring
+    _basestring = str
 except NameError:
----------------
Andi wrote:
> The contents of the try and except are now identical. Can this ever fail, or can the try/except be removed entirely now?
This seems like a construct to support both 2 and 3. So yeah basestring is no more in 3 so it could be removed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143703/new/

https://reviews.llvm.org/D143703



More information about the llvm-commits mailing list