[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

Fri Feb 10 08:58:24 PST 2023

aemerson added a comment.

In D143624#4118341 <https://reviews.llvm.org/D143624#4118341>, @dmgreen wrote:

>> It’s not clear from the original commit message why the test is related to inlining order? It seems entirely testing vectorization cost model which should be insensitive to these kind of changes, right?
>
> It's a phase ordering test - it's testing the entire pipeline including all the inlining and simplification that needs to happen :)
>
> You can run update_test_checks of the file to see the differences. I believe the inlining causes differences in the code that then cause different vector factors to be chosen. I can try to add a similar test for the other case that got worse, if they are similar.

I’ll take a look, but this indicates to me that there’s something missing from the vectoriser or later passes rather than a problem with the inliners behaviour.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143624/new/

https://reviews.llvm.org/D143624