[PATCH] D143619: [llvm][codegen] Disallow default Emulated TLS for RISCV

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

To put another perspective on issue #59500 <https://github.com/llvm/llvm-project/issues/59500> - I'd say there was some initial discussion that trailed off over the christmas/new year period. It's a seemingly simple change, but people who are experts in this area raised concern about whether it's necessary/worthwhile. Your patch in D143708 <https://reviews.llvm.org/D143708> helpfully summarises the key arguments and also points to information that was new to me (OpenBSD carry a patch for this downstream and thus it has presumably been tested and solves their problem). I'm sorry if the experience of discussing this missing feature is frustrating, but I hope you can also see the other side. There's no "tyranny" (we'd need a universally agreed viewpoint for that I think!), just a group of contributors trying their best.

I'll continue the discussion about enabling emulated TLS in D143708 <https://reviews.llvm.org/D143708>. @vit9696 perhaps you could remove the "requires changes to proceed" marker, unless you have specific quality of implementation concerns with this patch? It might be we decide to abandon it in favour of enabling emulated TLS, but even if it's just the case that it takes a little longer to agree on that, this patch is still better than the status quo where it sounds like we're generating incorrect code and might be reasonable stop-gap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143619/new/

https://reviews.llvm.org/D143619