[PATCH] D143711: [ARM] Fix Crash in 't'/'w' handling without fp16/fp16

Fri Feb 10 07:21:09 PST 2023

olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

LGTM, with one comment in the test.

================
Comment at: llvm/test/CodeGen/ARM/inlineasm-fp-half.ll:9

-define arm_aapcscc half @f_t(half %x) nounwind {
-; CHECK-LABEL: f_t:
-; CHECK:       @ %bb.0: @ %entry
-; CHECK-NEXT:    vmov.f16 s0, r0
-; CHECK-NEXT:    @APP
-; CHECK-NEXT:    vsqrt.f16 s0, s0
-; CHECK-NEXT:    @NO_APP
-; CHECK-NEXT:    vmov r0, s0
-; CHECK-NEXT:    bx lr
+; With FP16/BF16
+; RUN: llc -mtriple=arm-none-eabi -mattr=+armv8.2-a,+fp-armv8,+fullfp16,+bf16,-neon %s -o - | FileCheck %s --check-prefixes=FP16-SOFTFP
----------------
I think we should also have tests with FP16 but not BF16, because there are separate code paths for them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143711/new/

https://reviews.llvm.org/D143711