[PATCH] D139000: [AMDGPU] Remove function with incompatible features

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURemoveIncompatibleFunctions.cpp:10
+/// \file
+/// This pass replaces all uses of functions functions that use GPU features
+/// incompatible with the current GPU with null then deletes the function.
----------------
typo: functions repeated


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:1077
+
+  if (RemoveIncompatibleFunctions)
+    addPass(
----------------
For the sake of compile time, can we avoid running this pass on O2 and O3? We know dead code elimination will remove the functions anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000