[PATCH] D143729: [mlir][MemRef][TransformOps] Fix error reporting for multibuffer

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/TransformOps/MemRefTransformOps.cpp:29
   if (failed(newBuffer)) {
-    Diagnostic diag(target->getLoc(), DiagnosticSeverity::Note);
+    Diagnostic diag(target->getLoc(), DiagnosticSeverity::Remark);
     diag << "op failed to multibuffer";
----------------
qcolombet wrote:
> ftynse wrote:
> > We now have `emitSilenceableError() << "message"`, no need to do the creation dance manually here.
> Ah cool!
> Let me adopt that.
Don't hesitate to clean a few other things as you go: usage has not been consistently improved as you can see ..

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143729/new/

https://reviews.llvm.org/D143729