[PATCH] D142726: [Workflow] Add Release Repo sync script

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 03:56:42 PST 2023


kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.

LGTM except for a more detailed explanation in the comments at one place and except for a small change that slipped in because I requested too many changes ;)



================
Comment at: llvm/utils/git/sync-release-repo.sh:16-17
+# We will add two remotes here:
+#  main - which will point to $MAIN_URL
+#  release - which will point to $RELEASE_URL
+# The remotes will use random strings to avoid
----------------
Sorry to be nitpicking, but the `$MAIN_URL` and `$REMOTE_URL` variables no longer exist, Just add the `llvm/llvm-project` and `llvm/llvm-project-release-prs` repo references here is probably enough.


================
Comment at: llvm/utils/git/sync-release-repo.sh:45
+
+# Then we need to update again
+git fetch $MAIN_REMOTE
----------------
It would be nice to understand through the comment here what magic happens and why we need to update again before we can continue with the merge below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142726/new/

https://reviews.llvm.org/D142726



More information about the llvm-commits mailing list