[PATCH] D142621: [Couroutines] Modify CoroFrame materializable into a callback

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added a comment.

Thanks for the unit test!



================
Comment at: llvm/unittests/Transforms/Coroutines/ExtraRematTest.cpp:19
+
+struct ExtraRematTest : public testing::Test {
+  LLVMContext Ctx;
----------------
Maybe put the struct (or everything) into an anonymous namespace?


================
Comment at: llvm/unittests/Transforms/Coroutines/ExtraRematTest.cpp:146
+  Function *F = M->getFunction("f.resume");
+  assert(F && "could not find split function f.resume");
+
----------------
I think this should use a gtest macro, e.g. ASSERT_TRUE. Same for the other asserts.


================
Comment at: llvm/unittests/Transforms/Coroutines/ExtraRematTest.cpp:151
+
+  // With default materialization the intrinsic should not have be
+  // rematerialized
----------------
Typo at the end (have been?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142621/new/

https://reviews.llvm.org/D142621