[PATCH] D143710: [LoongArch] Emit addu16i.d for simple adds with eligible immediates

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 03:03:43 PST 2023


xen0n added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/add.ll:186
+
+define i32 @add_i32_0x12340000(i32 %x) {
+; LA32-LABEL: add_i32_0x12340000:
----------------
SixWeining wrote:
> Thanks.
> 
> Mabbe you can add these as baseline tests (no-functional-change or NFC patch)  :)
> https://github.com/llvm/llvm-project/blob/main/llvm/docs/TestingGuide.rst#precommit-workflow-for-tests
> 
> 
Okay I'll split patches shortly. Thanks for the suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143710/new/

https://reviews.llvm.org/D143710



More information about the llvm-commits mailing list