[PATCH] D143153: [Assignment Tracking][mem2reg] Remove overly defensive assert

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 01:57:27 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ad8f7a18957: [Assignment Tracking][mem2reg] Remove overly defensive assert (authored by Orlando).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143153/new/

https://reviews.llvm.org/D143153

Files:
  llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp


Index: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
===================================================================
--- llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
+++ llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
@@ -121,10 +121,8 @@
   void updateForDeletedStore(StoreInst *ToDelete, DIBuilder &DIB) const {
     // There's nothing to do if the alloca doesn't have any variables using
     // assignment tracking.
-    if (DbgAssigns.empty()) {
-      assert(at::getAssignmentMarkers(ToDelete).empty());
+    if (DbgAssigns.empty())
       return;
-    }
 
     // Just leave dbg.assign intrinsics in place and remember that we've seen
     // one for each variable fragment.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143153.496385.patch
Type: text/x-patch
Size: 709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230210/cbebfcf6/attachment.bin>


More information about the llvm-commits mailing list