[PATCH] D143619: [llvm][codegen] Disallow default Emulated TLS for RISCV

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 15:08:14 PST 2023


paulkirth marked an inline comment as done.
paulkirth added inline comments.


================
Comment at: lld/test/ELF/lto/riscv-no-emutls.ll:1
+; Ensure targets that normally enable emulated TLS by default, don't run the
+; LowerEmuTLSPass under LTO when targeting RISCV. Under LTO the backend options
----------------
MaskRay wrote:
> The test is added to the wrong layering https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer
> 
> 
I think the new test under `CodeGen/LTO/RISCV` should be better situated, but please let me know if you see another problem w/ the test structure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143619/new/

https://reviews.llvm.org/D143619



More information about the llvm-commits mailing list