[PATCH] D143681: [llvm][test] restrict 2 GVN tests to just test GVN (NFC)

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 14:56:08 PST 2023


nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/no_speculative_loads_with_asan.ll:19-20
+; CHECK-NEXT:    [[TMP8:%.*]] = bitcast i8* [[TMP7]] to i16*
+; CHECK-NEXT:    [[TMP9:%.*]] = load i16, i16* [[TMP8]], align 2
+; CHECK-NEXT:    [[TMP10:%.*]] = sext i16 [[TMP9]] to i32
+; CHECK-NEXT:    br label [[TMP11]]
----------------
I think these two instructions show that this whole test is kind of pointless IMO.

It's a copy of llvm/test/Transforms/GVN/no_speculative_loads_with_asan.ll, but using `newgvn` rather than `gvn` (unless I messed something up by converting this from `-O3`.

The `@TestNoAsan` case is the same as the `@TestAsan` case, so it just shows that NewGVN cannot elide redundant non-local loads. Am I understanding correctly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143681/new/

https://reviews.llvm.org/D143681



More information about the llvm-commits mailing list