[PATCH] D143600: [ELF][docs] Mention LLD_REPRODUCE and LLD_VERSION

Thu Feb 9 14:38:32 PST 2023

MaskRay added inline comments.

================
Comment at: lld/docs/ld.lld.1:892
+.Cm .comment
+indicating its version. The version string can be overridden by this environment variable.
+
----------------
peter.smith wrote:
> I recommend changing "indicating its version" to "containing the LLD version string."
> 
> The comment for getVersion() says:
> ``` 
> // Check LLD_VERSION first for ease of testing.                                                                                                                   // You can get consistent output by using the environment variable.                                                                                               // This is only for testing.
> ```
> perhaps worth adding. "This option is useful to eliminate differences in the binary caused by LLD version number differences."
Thanks for the suggestion!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143600/new/

https://reviews.llvm.org/D143600