[PATCH] D143677: [ValueTracking] Replace an always false condition with an assert.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2302
 
 static bool isKnownNonNullFromDominatingCondition(const Value *V,
                                                   const Instruction *CtxI,
----------------
craig.topper wrote:
> spatel wrote:
> > Change the function signature to take "Constant *C" instead of a generic "Value *"?
> We want to exclude constants.
Oops. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143677/new/

https://reviews.llvm.org/D143677