[PATCH] D143677: [ValueTracking] Replace an always true condition with an assert.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2302
 
 static bool isKnownNonNullFromDominatingCondition(const Value *V,
                                                   const Instruction *CtxI,
----------------
spatel wrote:
> Change the function signature to take "Constant *C" instead of a generic "Value *"?
We want to exclude constants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143677/new/

https://reviews.llvm.org/D143677