[PATCH] D143269: [DWARFLinker] Refactor cloneAddressAttribute().

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1174
+  //     beginning of its inlining function.
+  //  To avoid above cases and to not apply relocation twice(in applyValidRelocs
+  //  and here), read address attribute from InputDIE and apply Info.PCOffset
----------------



================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1206
 
-    // Generation of DWARFv5 .debug_addr table is not supported yet.
-    // Convert attribute into the dwarf::DW_FORM_addr.
+  // Generation of DWARFv5 .debug_addr table is not supported yet.
+  // Convert attribute into the dwarf::DW_FORM_addr.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143269/new/

https://reviews.llvm.org/D143269