[PATCH] D143678: [bazel] Add layering-check on CI

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 14:05:43 PST 2023


gchatelet added a subscriber: aeubanks.
gchatelet added a comment.

In D143678#4116423 <https://reviews.llvm.org/D143678#4116423>, @GMNGeoffrey wrote:

> `layering_check` has already been turned on at the package level for the packages that are layering clean (e.g. https://github.com/llvm/llvm-project/blob/main/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel#L15). You could add more

I did it originally for libc but got bitten by not setting it in the subfolders `BUILD.bazel` files.
Subfolder `BUILD.bazel` files create a new package that also needs to receive the feature.
@aeubanks suggested to add it to the `.blazerc` file instead to be more thorough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143678/new/

https://reviews.llvm.org/D143678



More information about the llvm-commits mailing list