[PATCH] D143662: [AMDGPU] Refactor multiclass FLAT_Atomic_Pseudo. NFC.

Thu Feb 9 11:40:14 PST 2023

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:469

-multiclass FLAT_Atomic_Pseudo<
+multiclass FLAT_Atomic_Pseudo_NO_RTN<
   string opName,
----------------
foad wrote:
> rampitec wrote:
> > This can be just a class now?
> Yes, and I did try that, but I preferred the consistency of having everything here be a multiclass. Note that both `FLAT_Global_Atomic_Pseudo_NO_RTN` and `FLAT_Global_Atomic_Pseudo_RTN` have to be multiclasses because they have to define additional _SADDR variants.
> 
> Do you feel strongly that it should be a class?
No, not really.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143662/new/

https://reviews.llvm.org/D143662