[PATCH] D142621: [Couroutines] Modify CoroFrame materializable into a callback

Thu Feb 9 08:42:39 PST 2023

dstuttard added a comment.

In D142621#4115184 <https://reviews.llvm.org/D142621#4115184>, @dstuttard wrote:

> In D142621#4114357 <https://reviews.llvm.org/D142621#4114357>, @ChuanqiXu wrote:
>
>> While this is innocent and no harmful, I prefer to land this after we found a usage for this someday. It wouldn't be a problem to do such a NFC change any times.
>
> We have a use-case for this change for one of our backends.

To expand on this - we have a tool based on LLVM that already adds extra materialization options. This change was to enable generic support to extend materialization determination so that we can simplify our code  to not have patches on top of upstream llvm.
I can imagine other groups having similar requirements - none of which would necessarily end up back in core llvm.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142621/new/

https://reviews.llvm.org/D142621