[PATCH] D143648: [AMDGPU][GlobalISel] Fix selection of image sample g16 instructions

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.g16.a16.dim.ll:860
 
+define amdgpu_ps <4 x float> @sample_d_1d_g16_a16(<8 x i32> inreg %rsrc, <4 x i32> inreg %samp, half %dsdh, half %dsdv, half %s) {
+; GFX10-LABEL: sample_d_1d_g16_a16:
----------------
foad wrote:
> How would these new tests fail without your patch? Would they fail machine verification?
GlobalISel was selecting non g16 variant without a crash or fail. There were no test cases with a16 and g16.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143648/new/

https://reviews.llvm.org/D143648