[PATCH] D143576: [LowerTypeTests] Support generating Armv6-M jump tables.

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 04:07:57 PST 2023


lenary added a comment.

Offline, I suggested to Simon that the info about whether you have thumb2 is available in two places: in the subtarget, and also in the target triple's subarch, and that maybe he could use the latter instead of adding an arm-architecture-specific hook to TTI (which would be better to avoid). He reported that the final subarch during LTO depends on the object order during the link, rather than on something more determinstic, and therefore using the triple feels to me less reliable than the current approach in this patch.

On that basis, it seems the arm-architecture-specific TTI hook is the least worst approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143576/new/

https://reviews.llvm.org/D143576



More information about the llvm-commits mailing list