[PATCH] D141850: [SCEV] Preserve divisibility and min/max information in applyLoopGuards

[Alon Kom via Phabricator via llvm-commits]

alonkom added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:15083
+          auto IsMin =
+              isa<SCEVSMinExpr>(MinMaxExpr) || isa<SCEVUMinExpr>(MinMaxExpr);
+          auto DivisibleExpr =
----------------
mkazantsev wrote:
> Do you really support `smin` here? Your code is only correct for unsigned values. It interprets all values as non-negative.
I check if the operands are non-negative inside GetPreviousSCEV/GetNextSCEVD


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141850/new/

https://reviews.llvm.org/D141850