[PATCH] D143143: [AArch64] Reassociate sub(x, add(m1, m2)) to sub(sub(x, m1), m2)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Given @dmgreen's point about the number of patterns that would be required the current patch seems like a more general solution.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17746
+    return SDValue();
+  SDValue N00 = Add.getOperand(0);
+  SDValue N01 = Add.getOperand(1);
----------------
It might be good to use the same names here as in the comment above, i.e. `m1` and `m2`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143143/new/

https://reviews.llvm.org/D143143