[PATCH] D143633: [AMDGPU] Ignore unused bits in VINTERP encoding

[Jay Foad via Phabricator via llvm-commits]

foad created this revision.
foad added reviewers: AMDGPU, dp, rampitec, piotr, Joe_Nash.
Herald added subscribers: kosarev, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

In the GFX11 VINTERP encoding bits 23, 59 and 60 are unused. Change the
disassembler to ignore these bits.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143633

Files:
  llvm/lib/Target/AMDGPU/VINTERPInstructions.td
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt


Index: llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt
===================================================================
--- llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt
+++ llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt
@@ -3,6 +3,9 @@
 # GFX11: v_interp_p10_f32 v0, v1, v2, v3{{$}}
 0x00,0x00,0x00,0xcd,0x01,0x05,0x0e,0x04
 
+# GFX11: v_interp_p10_f32 v0, v1, v2, v3{{$}}
+0x00,0x00,0x80,0xcd,0x01,0x05,0x0e,0x1c
+
 # GFX11: v_interp_p10_f32 v1, v10, v20, v30{{$}}
 0x01,0x00,0x00,0xcd,0x0a,0x29,0x7a,0x04
 
Index: llvm/lib/Target/AMDGPU/VINTERPInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/VINTERPInstructions.td
+++ llvm/lib/Target/AMDGPU/VINTERPInstructions.td
@@ -23,7 +23,6 @@
 
   let Inst{31-26} = 0x33; // VOP3P encoding
   let Inst{25-24} = 0x1; // VINTERP sub-encoding
-  let Inst{23}    = 0; // reserved
 
   let Inst{7-0}   = vdst;
   let Inst{10-8}  = waitexp;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143633.496055.patch
Type: text/x-patch
Size: 971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230209/e57aa3dd/attachment.bin>