[PATCH] D143600: [ELF][docs] Mention LLD_REPRODUCE and LLD_VERSION

Thu Feb 9 02:00:50 PST 2023

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

LGTM, a couple of small suggestions.

================
Comment at: lld/docs/ld.lld.1:7
 .\" from FreeBSD.
-.Dd May 12, 2019
+.Dd Feb 9, 2022
 .Dt LD.LLD 1
----------------
Did you mean Feb 9, 2023?

================
Comment at: lld/docs/ld.lld.1:892
+.Cm .comment
+indicating its version. The version string can be overridden by this environment variable.
+
----------------
I recommend changing "indicating its version" to "containing the LLD version string."

The comment for getVersion() says:
``` 
// Check LLD_VERSION first for ease of testing.                                                                                                                   // You can get consistent output by using the environment variable.                                                                                               // This is only for testing.
```
perhaps worth adding. "This option is useful to eliminate differences in the binary caused by LLD version number differences."

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143600/new/

https://reviews.llvm.org/D143600