[PATCH] D143620: [RISCV] Use OS-specific SafeStack ABI for Fuchsia

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13272
   SDNode *Copy = *N->use_begin();
-  
   if (Copy->getOpcode() == ISD::BITCAST) {
----------------
Leave unrelated functions alone


================
Comment at: llvm/test/Transforms/SafeStack/RISCV/abi.ll:4
+define void @unsafe_stack_escapes() nounwind safestack {
+; TLS: %[[TP:.*]] = call ptr @llvm.thread.pointer()
+;; Another platform with a different TP offset would use PLATFORM: here.
----------------
This is way too complicated and confusing to read. Just use --check-prefix=FUCHSIA and use update_test_checks.py to generate the CHECK lines. And probably this should have a non-Fuschia test too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143620/new/

https://reviews.llvm.org/D143620