[PATCH] D136400: [llvm-ocaml] Migrate from naked pointers to prepare for OCaml 5
Josh Berdine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 8 15:29:05 PST 2023
jberdine requested changes to this revision.
jberdine added a comment.
This revision now requires changes to proceed.
Only a partial review so far.
================
Comment at: llvm/bindings/ocaml/llvm/llvm.ml:444
= "llvm_set_module_inline_asm"
external module_context : llmodule -> llcontext = "LLVMGetModuleContext"
----------------
Missed wrapping this function to decode args and encode result.
================
Comment at: llvm/bindings/ocaml/llvm/llvm.ml:513
external element_type : lltype -> lltype = "LLVMGetElementType"
external array_length : lltype -> int = "llvm_array_length"
----------------
Missed wrapping this function to decode args and encode result.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136400/new/
https://reviews.llvm.org/D136400
More information about the llvm-commits
mailing list