[PATCH] D143537: [Object][NFC] Factor out computeHeadersSize.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 14:23:44 PST 2023


mstorsjo added a comment.

In D143537#4113938 <https://reviews.llvm.org/D143537#4113938>, @mstorsjo wrote:

> I didn't follow the actual refactoring here yet (it seems at least somewhat nontrivial) - but if this is indeed a pure refactoring, add `NFC` ("no functional change") as marker to the end of the commit message; in principle, commits are either NFC (with no changes to tests), or if there's a functional change, it should also have a matching test update.

Oh, sorry, I somehow entirely missed that this patch already had the NFC tag. Sorry for the noise...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143537/new/

https://reviews.llvm.org/D143537



More information about the llvm-commits mailing list