[PATCH] D143602: Allow 32-bit pointers to be written in 64-bit slots

David M. Lloyd via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 14:19:23 PST 2023


dmlloyd added inline comments.


================
Comment at: test/CodeGen/WebAssembly/ptrtoint-widen.ll:4
+ at ptr = external global i8, align 1
+ at ref = constant i64 ptrtoint (ptr @ptr to i64), align 8
+
----------------
arsenm wrote:
> Can you include some tests with different sized result integers? I thought that was the point of the patch 
For these two targets, the native pointer size is 32 bits, so `i64` *is* the different-sized result. But I can also add in the native size and a shorter one for good measure. I will look around other tests to figure out how the CHECK would work in those cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143602/new/

https://reviews.llvm.org/D143602



More information about the llvm-commits mailing list