[PATCH] D137094: [llvm-readobj] Fix "Section" output when emitting relocations in JSON

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 12:15:22 PST 2023


aidengrossman added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6727
+                                              const unsigned SecNdx) {
+  W.startLine() << "Section (" << SecNdx << ") " << Name << " {\n";
+  W.indent();
----------------
If this section is already getting moved around, it might be worth it to transition to a `DictScope` here as well (similar to what I did in D143310, but with proper string formatting logic) to leave all the formatting in a centralized place and simplify this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137094/new/

https://reviews.llvm.org/D137094



More information about the llvm-commits mailing list