[PATCH] D136163: Port PlaceSafepoints pass to the new pass manager

[Sebastian Peryt via Phabricator via llvm-commits]

speryt added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/PlaceSafepoints.cpp:101
 
+#pragma region Backedge Safepoints Pass(legacy only)
 namespace {
----------------
aeubanks wrote:
> not sure what this is for, but it's not used elsewhere in LLVM so it probably shouldn't be added here
This is most likely something specific to Visual Studio editor. There is short comment about that in `clang/lib/Lex/Pragma.cpp`

```
/// Handle "\#pragma region [...]"
///
/// The syntax is
/// \code
///   #pragma region [optional name]
///   #pragma endregion [optional comment]
/// \endcode
///
/// \note This is
/// <a href="http://msdn.microsoft.com/en-us/library/b6xkz944(v=vs.80).aspx">editor-only</a>
/// pragma, just skipped by compiler.
struct PragmaRegionHandler : public PragmaHandler
```

So it seems it's safe to drop those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136163/new/

https://reviews.llvm.org/D136163